feat(core): add S3 wire checksum download stream#2102
Draft
trivikr wants to merge 2 commits into
Draft
Conversation
trivikr
force-pushed
the
wire-checksum-stream
branch
from
June 25, 2026 21:19
923b689 to
81f9eed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Internal JS-6752
Description of changes:
Add createWireChecksumStream with Node.js and browser/web-stream
implementations that validate an S3 wire checksum over a GetObject
response body without buffering the full payload.
The checksum is delivered in the aws-chunked trailer, so the stream
delegates framing decode to a new incremental AwsChunkedDecoder: it
strips chunk framing, surfaces only decoded object data to the caller,
computes the checksum over those bytes, and reads the expected value
from the trailer. Validation runs at end-of-stream and optionally
verifies the decoded byte count against x-amz-decoded-content-length.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.