fix: auto-hide the header on desktop scroll - #34
Merged
Conversation
The scroll handler already marked the header hidden while scrolling down, but the transform was scoped to the mobile breakpoint. Move the hidden-state rule out of the media query so desktop navigation follows the same hide-on-down, reveal-on-up behavior while preserving the mobile-menu exception. Signed-off-by: Aoi <aione.moe.dev@gmail.com>
Aionw
marked this pull request as ready for review
August 3, 2026 03:46
slin1237
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header scroll handler already toggled
site-header--hiddenafter downward scrolling, but the matching transform rule lived inside the mobile-only breakpoint. On desktop, the state changed without any visual effect, leaving the full navigation bar pinned at the top.Move the hidden-state rule to the shared header styles so desktop and mobile both hide on downward scroll and reveal on upward scroll. The existing mobile-menu exception remains intact, keeping the header visible while the menu is open.
Verification
prettier --check ./eslint .— cleansvelte-check— 0 errors (1 pre-existing warning inHeroMark.svelte, untouched)wrangler pages dev—/smg/returns 200