Skip to content

Fix typespecs #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szajbus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typespecs #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/currency_formatter.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ defmodule CurrencyFormatter do
"A$1,234.56"

"""
@spec format(String.t() | number | atom, String.t()) :: String.t()
@spec format(String.t() | number, atom | String.t()) :: String.t()
def format(number, currency, opts \\ [])

def format(number, currency, opts) when is_atom(currency) do
Expand Down Expand Up @@ -254,7 +254,7 @@ defmodule CurrencyFormatter do
"A$"

"""
@spec symbol(atom) :: String.t()
@spec disambiguous_symbol(atom) :: String.t()
def disambiguous_symbol(currency) do
currency
|> CurrencyFormatter.instructions()
Expand Down Expand Up @@ -289,7 +289,7 @@ defmodule CurrencyFormatter do
@spec split_units_and_subunits(binary) :: [binary]
defp split_units_and_subunits(string), do: String.split(string, ",", parts: 2)

@spec handle_cents(list, map, map) :: String.t()
@spec handle_cents(list, map, Keyword.t()) :: String.t()
defp handle_cents([x, "00" = y], format, opts) do
if Keyword.get(opts, :keep_decimals) do
set_separators(x, format) <> format["decimal_mark"] <> y
Expand Down Expand Up @@ -355,7 +355,7 @@ defmodule CurrencyFormatter do
Phoenix.HTML.Tag.content_tag(:span, text, class: class)
end

@spec get_symbol(map, keyword | nil) :: String.t()
@spec get_symbol(map, Keyword.t()) :: String.t()
defp get_symbol(config, opts \\ Keyword.new()) do
if Keyword.get(opts, :disambiguate),
do: get_disambiguous_symbol(config),
Expand Down