Skip to content

Add missing case#158

Merged
denislavstanchev merged 3 commits into
mainlinefrom
add-missing-case
Jul 13, 2026
Merged

Add missing case#158
denislavstanchev merged 3 commits into
mainlinefrom
add-missing-case

Conversation

@denislavstanchev

Copy link
Copy Markdown
Contributor

Pull Request

Description

  • Add case for a template resource_type in append_data method in PaginatedChildrenResult model

Related Issue

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Code refactoring
  • Other (please describe):

Environment Information

  • Smartsheet API Version: [e.g. 2.0]
  • Smartsheet Python SDK Version: [e.g. 3.0.0]
  • Python Version: [e.g. 3.10]

What Changes Were Made

Why These Changes Were Made

Testing

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have updated the relevant files in docs-source/ (see Documentation guidelines)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

@coveralls

coveralls commented Jul 10, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 29234468635

Warning

No base build found for commit 6fcbc1c on mainline.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 77.693%

Details

  • Patch coverage: 4 of 4 lines across 1 file are fully covered (100%).

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 10835
Covered Lines: 8418
Line Coverage: 77.69%
Coverage Strength: 3.88 hits per line

💛 - Coveralls

@ggyurchev ggyurchev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a test case

@denislavstanchev
denislavstanchev merged commit 3433b49 into mainline Jul 13, 2026
32 of 57 checks passed
@denislavstanchev
denislavstanchev deleted the add-missing-case branch July 13, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants