Skip to content

Add report column builder - #187

Merged
zgeorgiev-smartsheet merged 2 commits into
mainlinefrom
add-report-column-builder-to-sdk
Jul 22, 2026
Merged

Add report column builder#187
zgeorgiev-smartsheet merged 2 commits into
mainlinefrom
add-report-column-builder-to-sdk

Conversation

@zgeorgiev-smartsheet

@zgeorgiev-smartsheet zgeorgiev-smartsheet commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Summary

Adds ReportColumn.AddReportColumnBuilder - a fluent builder for constructing ReportColumn objects when adding columns to a report. The builder enforces required fields (title and type), throwing InstantiationError if either is missing at build time.

Summary by CodeRabbit

  • New Features
    • Added a fluent builder for creating report columns with configurable titles, types, ordering, options, symbols, system column settings, auto-number format, width, primary flag, formatting, validation, and sheet-name behavior.
    • Added validation so required column details (title and type) must be provided before a column can be created.
  • Tests
    • Added unit test coverage for builder configuration, defaults, and required-field validation.
    • Updated existing report-column test setup to use the new builder.
  • Documentation
    • Updated the Unreleased changelog to mention the new builder.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4fc612fa-3ddd-48e3-acd7-c2b7f24c6955

📥 Commits

Reviewing files that changed from the base of the PR and between 86ffff3 and bc7d5a0.

📒 Files selected for processing (1)
  • CHANGELOG.md

📝 Walkthrough

Walkthrough

Adds ReportColumn.AddReportColumnBuilder with required-field validation, tests its property mapping and defaults, adopts it in report column test setup, and documents the addition.

Changes

Report column construction

Layer / File(s) Summary
ReportColumn builder implementation
src/main/java/com/smartsheet/api/models/ReportColumn.java
Adds a fluent builder for report column properties and throws InstantiationError when title or type is missing.
Builder validation and adoption
src/test/java/com/smartsheet/api/models/ReportColumnTest.java, src/test/java/com/smartsheet/api/sdktest/reports/TestAddReportColumns.java, CHANGELOG.md
Tests populated values, default sheet-name behavior, and required-field failures; report setup uses the builder and the changelog documents it.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description has a summary, but it omits the required checklist and any issue or task reference. Add the checklist items from the template, and include a task or issue link if one exists.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding a report column builder.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-report-column-builder-to-sdk

Comment @coderabbitai help to get the list of available commands.

ggoranov-smar
ggoranov-smar previously approved these changes Jul 22, 2026
@zgeorgiev-smartsheet
zgeorgiev-smartsheet merged commit ea0e888 into mainline Jul 22, 2026
3 checks passed
@zgeorgiev-smartsheet
zgeorgiev-smartsheet deleted the add-report-column-builder-to-sdk branch July 22, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants