Add proofs support for getSheet and getReport#186
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a ChangesProof SDK support
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
ggoranov-smar
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
proofsinclusion support togetSheetandgetReport.Changes
Proofmodel (com.smartsheet.api.models.Proof) andProofTypeenum (DOCUMENT, IMAGE, MIXED, NONE, VIDEO)proofproperty toAbstractRow, so it surfaces on bothRowandReportRowPROOFSinclude value toSheetInclusionandReportInclusionProof(getters/setters + wire-name serialization) and extendedReportResourcesImplTestto assert row-levelproofdeserializationNo changes needed to method signatures or query serialization — the new enum value flows through
QueryUtiland serializes toproofsautomatically.DEVECO-2197
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Proofmodel andProofTypeenum.PROOFSinclusion options for sheets, reports, and rows.Tests