-
Notifications
You must be signed in to change notification settings - Fork 27
Add data classification endpoint support #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ivelev96
wants to merge
4
commits into
mainline
Choose a base branch
from
feature/DEVECO-1386-data-classification-java
base: mainline
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
src/main/java/com/smartsheet/api/models/DataClassification.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| * Copyright (C) 2026 Smartsheet | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.smartsheet.api.models; | ||
|
|
||
| import com.smartsheet.api.models.enums.DataClassificationType; | ||
|
|
||
| /** | ||
| * Represents the data classification of a sheet. | ||
| */ | ||
| public class DataClassification { | ||
|
|
||
| private DataClassificationType dataClassification; | ||
|
|
||
| /** | ||
| * Gets the data classification. | ||
| * | ||
| * @return the data classification | ||
| */ | ||
| public DataClassificationType getDataClassification() { | ||
| return dataClassification; | ||
| } | ||
|
|
||
| /** | ||
| * Sets the data classification. | ||
| * | ||
| * @param dataClassification the data classification | ||
| * @return this DataClassification object for chaining | ||
| */ | ||
| public DataClassification setDataClassification(DataClassificationType dataClassification) { | ||
| this.dataClassification = dataClassification; | ||
| return this; | ||
| } | ||
| } | ||
27 changes: 27 additions & 0 deletions
27
src/main/java/com/smartsheet/api/models/enums/DataClassificationType.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /* | ||
| * Copyright (C) 2026 Smartsheet | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.smartsheet.api.models.enums; | ||
|
|
||
| /** | ||
| * Represents the data classification level of a sheet. | ||
| */ | ||
| public enum DataClassificationType { | ||
| PUBLIC, | ||
| INTERNAL, | ||
| CONFIDENTIAL, | ||
| SECRET, | ||
| } |
21 changes: 21 additions & 0 deletions
21
src/test/java/com/smartsheet/api/sdktest/sheets/CommonTestConstants.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| /* | ||
| * Copyright (C) 2025 Smartsheet | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.smartsheet.api.sdktest.sheets; | ||
|
|
||
| public class CommonTestConstants { | ||
| public static final long TEST_SHEET_ID = 1234567890123456L; | ||
| } |
92 changes: 92 additions & 0 deletions
92
src/test/java/com/smartsheet/api/sdktest/sheets/TestDeleteDataClassification.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /* | ||
| * Copyright (C) 2025 Smartsheet | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.smartsheet.api.sdktest.sheets; | ||
|
|
||
| import com.github.tomakehurst.wiremock.verification.LoggedRequest; | ||
| import com.smartsheet.api.Smartsheet; | ||
| import com.smartsheet.api.SmartsheetException; | ||
| import com.smartsheet.api.WiremockClient; | ||
| import com.smartsheet.api.WiremockClientWrapper; | ||
| import com.smartsheet.api.sdktest.Utils; | ||
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import java.net.URI; | ||
| import java.util.UUID; | ||
|
|
||
| import static com.smartsheet.api.sdktest.sheets.CommonTestConstants.TEST_SHEET_ID; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| public class TestDeleteDataClassification { | ||
|
|
||
| @Test | ||
| void testDeleteDataClassificationGeneratedUrlIsCorrect() throws SmartsheetException { | ||
| String requestId = UUID.randomUUID().toString(); | ||
| WiremockClientWrapper wrapper = Utils.createWiremockSmartsheetClient( | ||
| "/sheets/delete-data-classification/all-response-body-properties", | ||
| requestId | ||
| ); | ||
| Smartsheet smartsheet = wrapper.getSmartsheet(); | ||
| WiremockClient wiremockClient = wrapper.getWiremockClient(); | ||
|
|
||
| smartsheet.sheetResources().deleteDataClassification(TEST_SHEET_ID); | ||
| LoggedRequest wiremockRequest = wiremockClient.findWiremockRequest(requestId); | ||
| String path = URI.create(wiremockRequest.getUrl()).getPath(); | ||
|
|
||
| assertThat(path).isEqualTo("/2.0/sheets/" + TEST_SHEET_ID + "/dataclassification"); | ||
| } | ||
|
|
||
| @Test | ||
| void testDeleteDataClassificationAllResponseBodyProperties() { | ||
| String requestId = UUID.randomUUID().toString(); | ||
| WiremockClientWrapper wrapper = Utils.createWiremockSmartsheetClient( | ||
| "/sheets/delete-data-classification/all-response-body-properties", | ||
| requestId | ||
| ); | ||
| Smartsheet smartsheet = wrapper.getSmartsheet(); | ||
|
|
||
| Assertions.assertDoesNotThrow(() -> | ||
| smartsheet.sheetResources().deleteDataClassification(TEST_SHEET_ID) | ||
| ); | ||
| } | ||
|
|
||
| @Test | ||
| void testDeleteDataClassificationError500Response() { | ||
| String requestId = UUID.randomUUID().toString(); | ||
| WiremockClientWrapper wrapper = Utils.createWiremockSmartsheetClient("/errors/500-response", requestId); | ||
| Smartsheet smartsheet = wrapper.getSmartsheet(); | ||
|
|
||
| SmartsheetException exception = Assertions.assertThrows(SmartsheetException.class, () -> | ||
| smartsheet.sheetResources().deleteDataClassification(TEST_SHEET_ID) | ||
| ); | ||
|
|
||
| assertThat(exception.getMessage()).isEqualTo("Internal Server Error"); | ||
| } | ||
|
|
||
| @Test | ||
| void testDeleteDataClassificationError400Response() { | ||
| String requestId = UUID.randomUUID().toString(); | ||
| WiremockClientWrapper wrapper = Utils.createWiremockSmartsheetClient("/errors/400-response", requestId); | ||
| Smartsheet smartsheet = wrapper.getSmartsheet(); | ||
|
|
||
| SmartsheetException exception = Assertions.assertThrows(SmartsheetException.class, () -> | ||
| smartsheet.sheetResources().deleteDataClassification(TEST_SHEET_ID) | ||
| ); | ||
|
|
||
| assertThat(exception.getMessage()).isEqualTo("Malformed Request"); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be consistent with the C# SDK