This repository was archived by the owner on Jan 9, 2023. It is now read-only.
Add the suite of Mock API serialization tests to the C# SDK.#83
Open
armstnp wants to merge 3 commits into
Open
Add the suite of Mock API serialization tests to the C# SDK.#83armstnp wants to merge 3 commits into
armstnp wants to merge 3 commits into
Conversation
Author
|
Added tests for 'Change Agent' and 'Assume User' headers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were five serialization tests that failed in various ways, and are thus currently configured to be ignored:
BulkFailure
The failure for this one is pretty mysterious, as the JSON deserializer seems to expect more content, but it's unclear as to which content it expects and isn't seeing.
Predecessor
This has two points of failure:
AddRowsshould support query parameters (includespecifically, here), but does not; and the genericObjectValuetype is not deserialized from the response, currently. This test will need to be unignored and its assertions uncommented to be considered fully active once fixed.Sheet Settings
The Schedule object's 'Non-working days' field expects day-level granularity dates ('2018-10-10', e.g.), but the SDK always serializes it to full date-times.
Update Request
The Schedule object's
lastSentAtandnextSendAtfields ought to be optional, but instead are mandatory and sent with every request, instead of only being received by a Schedule response.User
The
profileImagefield expects a response ID namedimageId, notid, and so deserialization fails.