Skip to content

fix: make ITokenProvider.CreateHandler() public with proper XML docs - #1017

Merged
dennisoehme merged 1 commit into
nextfrom
copilot/fix-net-testing-results
Jun 8, 2026
Merged

fix: make ITokenProvider.CreateHandler() public with proper XML docs#1017
dennisoehme merged 1 commit into
nextfrom
copilot/fix-net-testing-results

Conversation

Copilot AI commented Jun 8, 2026

Copy link
Copy Markdown

PR #1001 introduced ITokenProvider.CreateHandler() as a public interface member but triggered two StyleCop build failures:

  • SA1615CreateHandler() was missing a <returns> XML doc tag
  • SA1518 — file had a trailing blank line (must end with exactly one newline)

Changes

  • src/Zitadel/Api/ITokenProvider.cs
    • Added <returns> tag to CreateHandler() XML documentation
    • Removed extra trailing blank line
/// <summary>
/// Creates the delegating handler for the token provider.
/// Made public to allow custom ITokenProvider implementations outside Zitadel.Net.
/// </summary>
/// <returns>A <see cref="DelegatingHandler"/> for the token provider.</returns>
public DelegatingHandler CreateHandler();

Copilot AI changed the title [WIP] Fix failing GitHub Actions job for .NET Testing fix: make ITokenProvider.CreateHandler() public with proper XML docs Jun 8, 2026
Copilot AI requested a review from dennisoehme June 8, 2026 17:04
@dennisoehme
dennisoehme changed the base branch from main to next June 8, 2026 17:04
Fixes SA1615 (add <returns> XML doc to CreateHandler) and SA1518
(ensure file ends with exactly one newline). Also changes the method
visibility from internal to public as intended by PR #1001 to allow
custom ITokenProvider implementations outside the Zitadel.Net assembly.
@dennisoehme
dennisoehme force-pushed the copilot/fix-net-testing-results branch from b8d63de to b26f014 Compare June 8, 2026 17:05
@dennisoehme
dennisoehme marked this pull request as ready for review June 8, 2026 17:06
@dennisoehme
dennisoehme merged commit 7537cee into next Jun 8, 2026
2 checks passed
@dennisoehme
dennisoehme deleted the copilot/fix-net-testing-results branch June 8, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants