fix: make ITokenProvider.CreateHandler() public with proper XML docs - #1017
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job for .NET Testing
fix: make ITokenProvider.CreateHandler() public with proper XML docs
Jun 8, 2026
Fixes SA1615 (add <returns> XML doc to CreateHandler) and SA1518 (ensure file ends with exactly one newline). Also changes the method visibility from internal to public as intended by PR #1001 to allow custom ITokenProvider implementations outside the Zitadel.Net assembly.
dennisoehme
force-pushed
the
copilot/fix-net-testing-results
branch
from
June 8, 2026 17:05
b8d63de to
b26f014
Compare
dennisoehme
marked this pull request as ready for review
June 8, 2026 17:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1001 introduced
ITokenProvider.CreateHandler()as a public interface member but triggered two StyleCop build failures:CreateHandler()was missing a<returns>XML doc tagChanges
src/Zitadel/Api/ITokenProvider.cs<returns>tag toCreateHandler()XML documentation