feat: add application and action v2 service client to clients helper - #1015
Open
merotosc wants to merge 2 commits into
Open
feat: add application and action v2 service client to clients helper#1015merotosc wants to merge 2 commits into
merotosc wants to merge 2 commits into
Conversation
merotosc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Clientshelper class to instantiate the API service clients currently does not contain the method to create an instance of the new V2ApplicationService.ApplicationServiceClientandActionService.ActionServiceClient.With this change a user can write
Clients.ApplicationService(...)orClients.ActionService(...)to instantiate the v2 application and action client.EDIT: The test case
ServiceAccountTest.Should_Throw_With_Meaningful_Errorfailed for me locally. I saw that also the renovate PRs failed for the same reason and also when running the tests locally on the main branch.