refactor(cubejs/profiler): enhance initial profile SQL generation for ClickHouse enums and arrays#51
Merged
Conversation
… ClickHouse enums and arrays - Updated the handling of ClickHouse Enum8/Enum16 types to use `uniq` instead of `uniqIf` to avoid invalid comparisons with empty strings. - Introduced a new utility function `isChEnumType` to identify Enum types. - Enhanced SQL generation for Array columns to include distinct counts and value rows. - Adjusted tests to validate the new behavior for Enum and Array types in the initial profiling process.
doktorhelgi
approved these changes
Apr 27, 2026
acmeguy
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.