Support asymetric lanes#1142
Open
agusaldasoro wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates token-transfer batch splitting to better handle asymmetric lane support, where chains may expose different pool types/versions for the same token pair.
Changes:
- Adds bidirectional compatibility checks when placing token transfer configs into batches.
- Adds an asymmetric-chain-support test case covering mixed BurnMint/LockRelease pool availability.
- Keeps batching deterministic through the existing sorted
buildTokenTransferBatchespath.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
build/devenv/deploy/deploy.go |
Adds compatibility filtering to the token transfer batch splitter. |
build/devenv/deploy/deploy_test.go |
Adds a regression test for asymmetric chain/pool support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Code coverage report:
|
archseer
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes token-transfer batching for asymmetric lane support.
Adds bidirectional selector compatibility checks when placing configs into batches.
Keeps deterministic batching order.
Adds an asymmetric BurnMint/LockRelease regression test.
Verifies expected split (3-config batch + 2-config batch) and reciprocal selector coverage.
Testing
Checklist
changelogdirectory)just lint fix- no new lint errorsjust generate- mocks and protobufs are up to date