fix: Increase fee limit to compensate for EIP-150 gas attenuation#1139
Open
nvsriram wants to merge 5 commits into
Open
fix: Increase fee limit to compensate for EIP-150 gas attenuation#1139nvsriram wants to merge 5 commits into
nvsriram wants to merge 5 commits into
Conversation
|
👋 nvsriram, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Collaborator
Author
Derivation for buffer
EIP-150 forwards at most Working backwards from Receiver to OffRamp: Therefore the additional gas required is: |
nvsriram
force-pushed
the
fix/CCIP-11515-eip150-gas-forwarding
branch
from
45cdeb7 to
335c17f
Compare
RensR
reviewed
Jun 1, 2026
| // eip150ForwardingGasBuffer returns the extra gas needed to compensate for EIP-150 | ||
| // gas attenuation across the OffRamp -> Router -> Receiver call path. | ||
| // It computes ceil(((64^2 - 63^2) / 63^2) * L), where L is the ccipReceive gas limit. | ||
| func eip150ForwardingGasBuffer(ccipReceiveGasLimit uint32) uint64 { |
Collaborator
There was a problem hiding this comment.
Could we add a simple unit tests that asserts something like this?
ccipReceiveGasLimit := 200_000
withBuffer := eip150ForwardingGasBuffer(ccipReceiveGasLimit)
assert(floor(withBuffer / 64 * 63 / 64 * 63), ccipReceiveGasLimit)
All of the current tests don't test this code, just that the function is being called.
|
Code coverage report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
executionGasLimitis currently used as the destination transaction fee limit. However, it does not account for EIP-150 forwarding at most ~63/64 gas with each external call.This PR compensates for this attenuation by adding a buffer ($\left\lceil{\frac{64}{63} \left\lceil{\frac{64}{63}L}\right\rceil}\right\rceil - L$ , where $L$ is the
ccipReceiveGasLimit) to account for the two external calls made by the OffRamp (Router -> Receiver).Testing
executionGasLimitandccipReceiveGasLimitdiffer