Move CCIPMessageSent event to ccip-runtime#731
Draft
friedemannf wants to merge 1 commit into
Draft
Conversation
friedemannf
changed the title
cfal
reviewed
Jun 29, 2026
|
|
||
| choice FinalizeSend : FinalizeSendResult | ||
| with | ||
| eventEmitter : ContractId CCIP.API.EventEmitterV1.EventEmitter |
Collaborator
There was a problem hiding this comment.
i don't quite understand the event emitter idea. if we place the events in its own package, eg ccip-events - then it doesn't need to be upgraded even if ccip-core or ccip-runtime are upgraded, and the same event could be created across upgrade versions. even if we update events in the future, we can just create a second events package eg ccip-events-v2 but still emit both v1 and v2 events for backwards compat eg with observability. what does this abstraction give us?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.