Implement 'Do' command and support Form referenced by 'Do' commands#820
Implement 'Do' command and support Form referenced by 'Do' commands#820DominikDostal wants to merge 1 commit into
Conversation
|
@DominikDostal Thank you for taking the time. I am currently very busy, but try to get back to you in more detail in the next weeks. In the meantime, would you be so kind and check #795, if it covers code you also changed? If that is the case I would see that we further discuss implementation details. |
Dont worry about it, take your time. I managed to make it work for my project, just wanted to share my findings with the community :)
I looked through it, but my PR doesnt seem to have any overlapping code with #795 |
Type of pull request
About
Added support for
Docommand for Issue #802Checklist for code / configuration changes
See CONTRIBUTING.md for all essential information about contributing.
Discuss the draft
Opened as Draft for now to show how I managed to make it work with my test pdf from #802
I think it's best to discuss the changes I had to make first, to find out if there is maybe a better way to do it:
$extractedTextscan be empty if all Text is inside the object referenced byDocommand-> Added a check to only skip all next commands if extracted text wasnt empty to begin with
extractRawDataandgetTextArraytakes content from the wrong property for Form objectsPage object gets it with
$content = $this->get('Contents');which takes it from theelementsarray defined in the Header objectForm object content can be access with:
I copied this part from another location and found that it worked. Im pretty sure we can create this object somewhere in the constructor of form or the factory, but sadly i didnt manage to find the place where i should do that.