fix: boilerplate CI + missing frontend Dockerfile (end-to-end ready)#1
Merged
Conversation
…te runs end-to-end - .github/workflows/ci.yml: runs backend unit tests, evals (stub), frontend build, and deploys backend image on main - frontend/Dockerfile.frontend: was referenced by docker-compose.yml but missing, so 'docker compose up --build' failed Verified: backend tests 5 passed, evals 4 passed/1 skipped (live gated on key), frontend builds, live server returns 200 on /health /api/chat /goals /api/runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
The boilerplate was NOT actually deployable/verifiable as-shipped:
.github/directory, so the claim that it 'should be connected to GitHub Actions and deploying' was false. Added.github/workflows/ci.ymlthat runs on pushes tomain/feature/v0.1and PRs: backend unit tests, evals (stub mode), frontend build, and a backend deploy-image build onmain.docker compose up --buildwould fail —docker-compose.ymlreferencesfrontend/Dockerfile.frontend, which did not exist. Added it (Vite dev server on :5173, deps installed at runtime into the node_modules volume, matching the compose bind-mount setup).Verified locally
tests/: 5 passedevals/: 4 passed, 1 skipped (test_live_chatcorrectly gated on API key)npm install+npm run build→ clean (tsc + vite)/health,POST /api/chat,POST /goals+/run,GET /api/runsall return 200Note for maintainer
AGENTS.md/README describe asrc/LangGraph skeleton; the actual code isbackend/app/(hand-rolled supervisor/worker, no LangGraph). Docs describe a different architecture than what ships. Should the docs be corrected or the code refactored to match? Left as-is pending your call — flagging, not changing.docker compose upwas not executed; CI will exercise the image build on push. Tests/build/runtime were verified directly.