Fuck around find out#2
Conversation
…ings, feature toggles, and improved session handling
…, and implement role-based system prompt extension
…esearcher, and Reviewer peers; enhance clarity and conciseness in documentation
…on in pi-agent.json, and enhance session management with new kill script
…reviewer, and memory agents
…ement with loop breaker and peer tools extensions
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2855ee8f7e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const projectDir = resolve(homedir(), "code", "dev", "pi-ghosty"); | ||
| const workDir = process.cwd(); | ||
|
|
||
| const env = loadEnv(); | ||
| const config = loadConfig(rootDir); | ||
| const config = loadConfig(projectDir); |
There was a problem hiding this comment.
main() now hardcodes projectDir to ~/code/dev/pi-ghosty and immediately calls loadConfig(projectDir), so any checkout located elsewhere will fail to start with ENOENT when reading pi-agent.json. This is a runtime regression from using process.cwd() and blocks normal npm run dev usage outside one specific machine path.
Useful? React with 👍 / 👎.
| const projectDir = resolve(homedir(), "code", "dev", "pi-ghosty"); | ||
| const workDir = cwd; | ||
|
|
||
| const env = loadEnv(); | ||
| const config = loadConfig(projectDir); | ||
| const runDir = resolveRunDir(env); |
There was a problem hiding this comment.
The session recreation callback used for interactive flows (/new, /resume) also hardcodes projectDir to ~/code/dev/pi-ghosty before reloading config, so session switching will fail in environments where the repo is not at that exact location. Even if the initial runtime is injected correctly, switching sessions reintroduces this path-dependent failure.
Useful? React with 👍 / 👎.
| ? (process.env.GHOSTY_RUN_DIR.startsWith("~") | ||
| ? resolve(homedir(), process.env.GHOSTY_RUN_DIR.slice(1)) | ||
| : resolve(process.env.GHOSTY_RUN_DIR)) |
There was a problem hiding this comment.
The kill script treats any value starting with ~ as resolve(homedir(), value.slice(1)); for the common ~/runs/pi-ghosty form, slice(1) produces an absolute path (/runs/pi-ghosty) and resolve ignores homedir(). This makes npm run kill read the wrong pidfile whenever users set GHOSTY_RUN_DIR with ~/....
Useful? React with 👍 / 👎.
… manual Transform the delegate SKILL.md from a brief guide into a detailed operator manual for the coordinator role. The new documentation includes: - Clear role definitions (coordinator vs workers) - Step-by-step delegation procedures with decision tables - Ground truth about peer capabilities and session behavior - Comprehensive troubleshooting and anti-patterns - Cross-peer analysis identifying consistency issues - Enhanced examples and edge case handling This improves clarity for operators delegating work to internal peers (coder, researcher, reviewer, memory) in the pi-ghosty system.
1 participant
No description provided.