Correct a typo in the text of the externalsort task and add a comment to the retryupdate task#18
Open
InventiveSpark wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pkositsyn
Исправление текста задачи externalsort и добавление комментария к задаче retryupdate.
На мой взгляд, название функции updateFn выбрано неудачно. Это вспомогательная функция UpdateValue, но сам ключ в сервисе она не обновляет – этим занимается функция UpdateValue. Т.е. в названиях функций слово "update" используется в двух разных значениях, что усложняет понимание. Добавил комментарий, объясняющий роль функции updateFn.
В тексте задания исправлена опечатка: упоминание названия несуществующей функции.