Skip to content

release: develop → main#164

Merged
join0life merged 10 commits into
mainfrom
develop
May 27, 2026
Merged

release: develop → main#164
join0life merged 10 commits into
mainfrom
develop

Conversation

@join0life

Copy link
Copy Markdown
Contributor

무엇을 변경했나요?

develop 브랜치를 main으로 머지

왜 이렇게 했나요?

(선택한 이유, 다른 방법 대신 이걸 선택한 이유)

리뷰어가 특히 봐줬으면 하는 부분

  • (예: 이 로직이 엣지케이스를 잘 처리하는지)

스크린샷 (UI 변경 시)

@join0life join0life self-assigned this May 27, 2026
@vercel

vercel Bot commented May 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bearlog Ready Ready Preview, Comment May 27, 2026 5:21am

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces several instances of router.push with router.replace to optimize navigation history, renames the onClose prop to onCloseAction in the NoteCloseButton component, and adds a placeholder ModalPage component. A review comment correctly points out a potential runtime crash when calling .get() on searchParams if it is null during static rendering, suggesting the use of optional chaining as a safeguard.

Comment on lines 665 to +666
const page = searchParams.get('page') ?? '1';
router.push(`/goal/${goalId}/note?page=${page}`);
router.replace(`/goal/${goalId}/note?page=${page}`);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

useSearchParams()는 Next.js에서 정적 렌더링(Static Rendering) 환경이나 빌드 시점에 null을 반환할 수 있습니다. searchParamsnull인 상태에서 .get()을 호출하면 런타임 에러가 발생하여 애플리케이션이 크래시될 수 있습니다. 안전한 실행을 위해 옵셔널 체이닝(?.)을 사용하여 방어적으로 코드를 작성하는 것이 좋습니다.

Suggested change
const page = searchParams.get('page') ?? '1';
router.push(`/goal/${goalId}/note?page=${page}`);
router.replace(`/goal/${goalId}/note?page=${page}`);
const page = searchParams?.get('page') ?? '1';
router.replace(`/goal/${goalId}/note?page=${page}`);

join0life added 4 commits May 27, 2026 14:01
Set CI environment variable and specify HOME directory for Playwright tests.
ci: playwright docker 이미지로 변경 및 push 트리거 제거
@join0life join0life merged commit 74457a4 into main May 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant