feat: zod 기반 회원가입 실시간 유효성 검사 적용#160
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the signup page to use react-hook-form and zod for form management and validation, replacing manual state handling. It also applies a specific text color to the submit buttons in both the login and signup flows. Feedback highlights that validation messages in the Zod schema should be internationalized using the t() function rather than being hardcoded. Additionally, it is recommended to move hardcoded hex colors into the Tailwind theme configuration to ensure design consistency and improve maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
무엇을 변경했나요?
zod 기반 회원가입 실시간 유효성 검사 적용
왜 이렇게 했나요?
버튼 클릭 후에만 에러가 표시되던 방식 -> 입력 중 즉시 피드백을 주는 방식
리뷰어가 특히 봐줬으면 하는 부분
스크린샷 (UI 변경 시)