This repository was archived by the owner on Jan 17, 2022. It is now read-only.
Add example for sorting by a dynamic Seq of columns#21
Open
cvogt wants to merge 1 commit into
Open
Conversation
Member
|
I'd rather apply sortBy calls for the individual keys in reverse order so you don't have to construct internal objects like Ordered manually and step outside of the type-safe lifted embedding API. |
Member
Author
|
@szeiger: I agree, updated the commit to do that |
Member
Author
|
@szeiger Please have a look. I'd like to answer some ML / SO postings with this. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
review by @szeiger