Add Toroid device support and update WireMetadata for charge toroids#33
Open
kabanaty wants to merge 2 commits into
Open
Add Toroid device support and update WireMetadata for charge toroids#33kabanaty wants to merge 2 commits into
kabanaty wants to merge 2 commits into
Conversation
eloise-nebula
approved these changes
Jul 24, 2026
eloise-nebula
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Just one comment. I'm approving. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Toroid devices to the codebase, enabling their creation, management, and integration with existing device handling infrastructure. The main changes include the implementation of the
Toroidclass and its supporting classes, updates to the device reader logic, and minor enhancements to related metadata structures.Toroid device support:
Toroidclass inslac_devices/toroid.py, along with supporting classesToroidPVSet,ToroidControlInformation, andToroidMetadata. These handle Toroid-specific process variables, control information, and metadata, and provide methods for accessing current and buffered TMIT values.slac_devices/reader.pyto import the newToroidclass and include "toroids" in the list of recognized device types and the device constructor map.Device creation enhancements:
create_toroidfunction toslac_devices/reader.pyfor instantiating Toroid devices by area and name, with error handling for invalid or missing data.Metadata improvements:
WireMetadataclass inslac_devices/wire.pyto include an optionalcharge_toroidsfield, allowing wire devices to reference associated Toroids.