Add optional jitter_bpms field to WireMetadata class - #30
Merged
Conversation
kabanaty
requested review from
eloise-nebula and
nneveu
and removed request for
eloise-nebula
June 10, 2026 22:22
eloise-nebula
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a small update to the
WireMetadataclass inslac_devices/wire.py, adding an optionaljitter_bpmsfield to support additional metadata.jitter_bpmsfield (a list of strings) to theWireMetadataclass to allow specifying BPMs relevant for jitter analysis.