Add dependencies and refactor buffer methods in multiple classes - #29
Merged
Conversation
…in BPM, LBLM, PMT, and Wire classes
…into new-buffer
kabanaty
commented
May 28, 2026
kabanaty
marked this pull request as ready for review
May 28, 2026 18:55
eloise-nebula
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modernizes how device classes interact with timing buffers and refactors the use of the
LazyPVclass. The main improvements are the adoption of the newBufferinterface fromslac_timing, the use ofLazyPVfromslac_toolsinstead of a local implementation, and updates to dependencies to support these changes.Buffer interface modernization:
bpm.py,lblm.py,pmt.py,wire.py) now use the newBufferinterface fromslac_timingfor timing data retrieval, replacing previous custom buffer logic and error handling. This results in cleaner and more consistent buffer access methods.Refactoring and dependency updates:
LazyPVimplementation indevice.pyis removed in favor of importingLazyPVfrom the newslac_toolsdependency, simplifying code maintenance and ensuring consistency across projects.pyproject.tomldependencies are updated to include bothslac-toolsandslac-timing, enabling the use of the new interfaces and utilities.Test updates:
PVclass intest_wire.pyis updated to reflect the move toslac_tools, ensuring tests continue to mock the correct class.