Implement PMT metadata retrieval and update device database - #47
Merged
Conversation
kabanaty
marked this pull request as ready for review
May 29, 2026 18:34
nneveu
approved these changes
Jun 1, 2026
nneveu
left a comment
Member
There was a problem hiding this comment.
Tyler will send an email to Andrea to add this information to the oracle DB. TODO: Make an issue to undo this after db is updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new YAML-based metadata system for PMTs, enabling richer and more maintainable metadata, particularly for the
beam_pathfield. The core logic inget_pmt_metadatais updated to load this metadata from a YAML file, and the PMT entries in several YAML configuration files are updated to include detailedbeam_pathinformation. Additionally, there are minor corrections and cleanups in device and wire YAML files, and an update to the device database file.PMT Metadata System Overhaul
pmt_metadata.yamlcontaining detailedbeam_pathinformation for each PMT, organized by accelerator region.get_pmt_metadatafunction inmetadata.pyto load PMT metadata from the new YAML file, replacing the previous placeholder implementation.PMT Metadata Population
beam_pathfield for PMTs in area YAML files (e.g.,DL1.yaml,LI21.yaml,DUMP.yaml,BSY.yaml) to match the new metadata, ensuring consistency across the codebase.Device and Wire Configuration Cleanups
Other Minor Updates
device.sqlite3) to a new version to reflect the above metadata changes.