Skip to content

Implement PMT metadata retrieval and update device database - #47

Merged
nneveu merged 3 commits into
slaclab:mainfrom
kabanaty:pmt-metadata
Jun 1, 2026
Merged

Implement PMT metadata retrieval and update device database#47
nneveu merged 3 commits into
slaclab:mainfrom
kabanaty:pmt-metadata

Conversation

@kabanaty

Copy link
Copy Markdown
Collaborator

This pull request introduces a new YAML-based metadata system for PMTs, enabling richer and more maintainable metadata, particularly for the beam_path field. The core logic in get_pmt_metadata is updated to load this metadata from a YAML file, and the PMT entries in several YAML configuration files are updated to include detailed beam_path information. Additionally, there are minor corrections and cleanups in device and wire YAML files, and an update to the device database file.

PMT Metadata System Overhaul

  • Added a new file pmt_metadata.yaml containing detailed beam_path information for each PMT, organized by accelerator region.
  • Refactored the get_pmt_metadata function in metadata.py to load PMT metadata from the new YAML file, replacing the previous placeholder implementation.

PMT Metadata Population

  • Populated the beam_path field for PMTs in area YAML files (e.g., DL1.yaml, LI21.yaml, DUMP.yaml, BSY.yaml) to match the new metadata, ensuring consistency across the codebase.

Device and Wire Configuration Cleanups

  • Removed unused TMITLoss BPM lists from several wire YAML files, streamlining their configuration.

Other Minor Updates

  • Updated the device database file (device.sqlite3) to a new version to reflect the above metadata changes.

@kabanaty
kabanaty marked this pull request as ready for review May 29, 2026 18:34

@nneveu nneveu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tyler will send an email to Andrea to add this information to the oracle DB. TODO: Make an issue to undo this after db is updated.

@nneveu
nneveu merged commit 7aab8bb into slaclab:main Jun 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants