chore: release#2628
Conversation
e7cd1e5 to
4f510d9
Compare
1549b3e to
acf2386
Compare
zimeg
left a comment
There was a problem hiding this comment.
@slack/web-api@7.17.1 — the queued #2627 changeset has a likely breaking request-side regression.
#2627 fixed the Lists message response shape, but changed it on the shared SlackListsItemField type:
message: string[] → SlackListsItemMessage | SlackListsItemMessage[]That union type backs both directions:
- request —
SlackListsItemsCreateArguments.initial_fields(slackLists.items.create/.update) - response —
SlackListsItem.fields
Per the docs, the request message field is an array of message permalink URL strings:
https://docs.slack.dev/reference/methods/slackLists.items.create/#field-types
So this patch now mistypes valid request input — anyone passing message: ["https://…/p123"] to initial_fields gets a type error. Because it removes a previously-accepted request shape (string[]), this is arguably a breaking change, not a patch-level fix.
Recommendation: split the request vs. response message field types before release — request keeps string[], response gets the object union — per the approach in #2600. Happy to fast-follow with that fix; flagging here so 7.17.1 doesn't ship the regression silently.
456b8e1 to
49550c0
Compare
|
🔭 I might press on landing #2640 for this release with the initial issue being saved for follow up? |
49550c0 to
ecf9c71
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2628 +/- ##
=======================================
Coverage 88.90% 88.90%
=======================================
Files 63 63
Lines 10256 10256
Branches 452 452
=======================================
Hits 9118 9118
Misses 1117 1117
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@mwbrooks Once more the review is so appreciated. Thanks! Let's now merge 🚀 🌃 |
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@slack/web-api@7.18.0
Minor Changes
thread_tsoptional forassistant.threads.setSuggestedPrompts@slack/webhook@7.1.0
Minor Changes
addAppMetadatafor external instrumentation use