-
Notifications
You must be signed in to change notification settings - Fork 682
fix(web-api): type Slack Lists message fieldFix Slack Lists message field response type responses #2621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+36
−2
Closed
fix(web-api): type Slack Lists message fieldFix Slack Lists message field response type responses #2621
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
211c417
fix(web-api): type Slack Lists message field responses
cxdmnls e78d493
Merge branch 'main' into fix-slack-lists-message-field-type
cxdmnls 23077c5
Merge branch 'main' into fix-slack-lists-message-field-type
cxdmnls 1d984cc
Merge branch 'main' into fix-slack-lists-message-field-type
cxdmnls File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
packages/web-api/test/types/methods/slacklists-response.test-d.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import { expectAssignable } from 'tsd'; | ||
| import type { SlackListsItemFieldMessage } from '../../../src/types/request/slackLists'; | ||
|
|
||
| expectAssignable<SlackListsItemFieldMessage>({ | ||
| column_id: 'Col123', | ||
| message: { | ||
| text: 'hello', | ||
| ts: '123.456', | ||
| user: 'U123', | ||
| team: 'T123', | ||
| type: 'message', | ||
| }, | ||
| }); | ||
|
|
||
| expectAssignable<SlackListsItemFieldMessage>({ | ||
| column_id: 'Col123', | ||
| message: [ | ||
| { | ||
| text: 'hello', | ||
| ts: '1234567890.123456', | ||
| user: 'U123', | ||
| team: 'T123', | ||
| type: 'message', | ||
| }, | ||
| ], | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐛 issue: This is breaking to the API input with an internal error shown in #2640