Skip to content

Claude/beautiful sagan jaufi #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skyRolly merged 2 commits into from
Jun 17, 2026
+515 −290
Merged

Claude/beautiful sagan jaufi #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a90cef
v0.6.8: Multiband UX overhaul, crossover slew-limit, A/B glitch purge…
claude Jun 17, 2026
4bf1c0f
v0.6.8: bump project version
claude Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ cmake_minimum_required(VERSION 3.22)
# cmake --build build --config Release
# ============================================================================

project(Anamorph VERSION 0.6.7 LANGUAGES C CXX)
project(Anamorph VERSION 0.6.8 LANGUAGES C CXX)

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
Expand Down
169 changes: 94 additions & 75 deletions src/PluginEditor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ AnamorphAudioProcessorEditor::AnamorphAudioProcessorEditor (AnamorphAudioProcess
metersToggle.onClick = [this] { metersOn = metersToggle.getToggleState(); }; // visibility via layoutScopeArea (#2)

setupToggle (advancedToggle, pid::advancedMode, "Adv", "Advanced mode"); // #17
advancedToggle.onClick = [this] { advanced = advancedToggle.getToggleState(); updateModeVisibility(); };
advancedToggle.onClick = [this] { advanced = advancedToggle.getToggleState(); applyUiScale(); updateModeVisibility(); };

setupToggle (bypassToggle, pid::bypass, "Bypass", {});
bypassToggle.setComponentID ("bypass");
Expand Down Expand Up @@ -473,9 +473,7 @@ AnamorphAudioProcessorEditor::AnamorphAudioProcessorEditor (AnamorphAudioProcess
setupToggle (mbEnableToggle, pid::mbEnable, "On", "Apply the per-band stereo widths to the sound");
imager = std::make_unique<anamorph::gui::SpectrumImager> (processor.getEngine().getScopeBuffer(),
processor.getAPVTS());
imager->setTooltip ("Drag a split to move it. Drag up / down in a band to set its width. "
"Click the top strip to add a split, the x to remove one. "
"Scroll to fine-tune; double-click or Alt-click to reset.");
imager->setTooltip ("Drag a band for its width; drag a split to move it. Click to add, x to remove.");
addAndMakeVisible (*imager);

// --- Overlays ---
Expand Down Expand Up @@ -575,9 +573,8 @@ AnamorphAudioProcessorEditor::AnamorphAudioProcessorEditor (AnamorphAudioProcess
updateModeVisibility();
uiAnimOn = animToggle.getToggleState();
refreshPresetDisplay();
setSize (kWidth, kHeight); // single fixed size for both modes (#20)
setResizable (false, false);
applyUiScale(); // recalled XS..XL window scale (F4)
applyUiScale(); // sets the base size (mode-dependent height) + XS..XL scale
startTimerHz (24);
// One vblank drives every per-frame animation: the meter reveal (#6) and the
// micro-animations (F3); both early-out to a few compares when idle.
Expand Down Expand Up @@ -632,7 +629,20 @@ void AnamorphAudioProcessorEditor::attachSlider (juce::Slider& s, const char* id

auto* p = processor.getAPVTS().getParameter (id);
if (auto* k = dynamic_cast<Knob*> (&s); k != nullptr && p != nullptr)
{
k->resetValue = p->getNormalisableRange().convertFrom0to1 (p->getDefaultValue()); // #6
// A RESET (double-click / Option-click) sweeps the eased position (0.6.7 #21).
k->onSweep = [this] { if (uiAnimOn) knobSweepTime = 0.45; };
}

// A TEXT-box value entry should also sweep, but a drag, the scroll wheel, and
// host AUTOMATION must NOT: text entry is the only one of those that changes the
// value while the control holds keyboard focus and the mouse is up (0.6.7 #21).
if (! s.onValueChange)
s.onValueChange = [this, &s] {
if (uiAnimOn && ! s.isMouseButtonDown() && s.hasKeyboardFocus (true))
knobSweepTime = 0.45;
};

// Tag the unit so the value box can show a bare number while editing (#36).
const juce::String sid (id);
Expand Down Expand Up @@ -833,6 +843,7 @@ void AnamorphAudioProcessorEditor::timerCallback()
if (advancedToggle.getToggleState() != advanced)
{
advanced = advancedToggle.getToggleState();
applyUiScale(); // resize for / against the Multiband bar (#2)
updateModeVisibility();
}
if (metersToggle.getToggleState() != metersOn)
Expand Down Expand Up @@ -1044,9 +1055,12 @@ void AnamorphAudioProcessorEditor::applyUiScale()
{
static constexpr float scales[] = { 0.75f, 0.85f, 1.0f, 1.25f, 1.5f };
const int idx = juce::jlimit (0, 4, uiScaleBox.getSelectedItemIndex());
if (idx == lastScaleIdx) return;
lastScaleIdx = idx;

// Advanced extends the window downward for the full-width Multiband bar instead
// of compressing the scope (0.6.7 #2). The base (unscaled) size depends on the
// mode; the XS..XL transform scales it.
setSize (kWidth, kHeight + (advanced ? kMultiBarH : 0));
setTransform (juce::AffineTransform::scale (scales[idx]));
if (openGLContext.isAttached())
openGLContext.triggerRepaint();
Expand Down Expand Up @@ -1199,8 +1213,8 @@ void AnamorphAudioProcessorEditor::paint (juce::Graphics& g)
g.setFont (juce::Font (juce::FontOptions (10.0f)).withExtraKerningFactor (0.25f));
g.drawText ("STEREO TOOLS", 168, 0, 140, 46, juce::Justification::centredLeft);

// Right control panel
auto right = juce::Rectangle<int> (getWidth() - 300, 46, 300, getHeight() - 46).toFloat().reduced (8.0f);
// Right control panel (spans the upper region only; the Multiband bar sits below)
auto right = juce::Rectangle<int> (getWidth() - 300, 46, 300, kHeight - 46).toFloat().reduced (8.0f);
g.setColour (colours::bgPanel.withAlpha (0.55f));
g.fillRoundedRectangle (right, 10.0f);

Expand All @@ -1213,16 +1227,20 @@ void AnamorphAudioProcessorEditor::paint (juce::Graphics& g)
g.setColour (colours::outline.withAlpha (0.6f));
g.drawLine (right.getX() + 12.0f, dy, right.getRight() - 12.0f, dy, 1.0f);

// Left column under the scope: a compact INPUT bar above a long,
// full-width MULTIBAND spectrum bar (0.6.6 #3/#9).
// INPUT strip at the bottom of the left column (inside the upper region),
// and a long, FULL-WIDTH MULTIBAND bar below the whole upper region (0.6.7 #2).
const int leftW = getWidth() - 300;
auto inputPanel = juce::Rectangle<int> (0, getHeight() - kStripHeight, leftW, kInputHeight)
.toFloat().reduced (8.0f, 6.0f);
auto multiPanel = juce::Rectangle<int> (0, getHeight() - kMultiHeight, leftW, kMultiHeight)
auto inputPanel = juce::Rectangle<int> (0, kHeight - kStripHeight, leftW, kStripHeight)
.toFloat().reduced (8.0f, 6.0f);
g.setColour (colours::bgPanel.withAlpha (0.5f));
g.fillRoundedRectangle (inputPanel, 10.0f);
g.fillRoundedRectangle (multiPanel, 10.0f);

if (getHeight() > kHeight)
{
auto multiPanel = juce::Rectangle<int> (0, kHeight, getWidth(), getHeight() - kHeight)
.toFloat().reduced (8.0f, 6.0f);
g.fillRoundedRectangle (multiPanel, 10.0f);
}
}
}

Expand All @@ -1231,7 +1249,9 @@ void AnamorphAudioProcessorEditor::paint (juce::Graphics& g)
// just this part per frame instead of the whole resized() (#6).
void AnamorphAudioProcessorEditor::layoutScopeArea()
{
auto leftArea = getLocalBounds().withTrimmedTop (46).withTrimmedRight (300);
// The scope/meter block lives in the upper region only (height kHeight), so the
// Multiband bar below never compresses it (0.6.7 #2).
auto leftArea = juce::Rectangle<int> (0, 46, getWidth() - 300, kHeight - 46);
if (advanced) leftArea.removeFromBottom (kStripHeight);

auto sa = leftArea.reduced (16);
Expand All @@ -1252,15 +1272,16 @@ void AnamorphAudioProcessorEditor::layoutScopeArea()
sa.removeFromLeft (juce::roundToInt (12.0f * meterAnim));
}

auto vCol = sa.removeFromRight (26);
sa.removeFromRight (8);
auto hRow = sa.removeFromBottom (26);
sa.removeFromBottom (8);
const int side = juce::jmin (sa.getWidth(), sa.getHeight());
auto sq = sa.withSizeKeepingCentre (side, side);
// Phase meter (right) + balance meter (bottom) hug the scope with an EQUAL gap,
// and the whole scope+meter cluster is centred in the area -- so the
// scope-to-phase and scope-to-balance gaps always match (0.6.7 #3).
const int gap = 8, barW = 26;
const int side = juce::jmin (sa.getWidth() - barW - gap, sa.getHeight() - barW - gap);
auto cluster = sa.withSizeKeepingCentre (side + gap + barW, side + gap + barW);
auto sq = juce::Rectangle<int> (cluster.getX(), cluster.getY(), side, side);
scope->setBounds (sq);
corrMeter->setBounds (vCol.withHeight (side).withY (sq.getY()));
balanceMeter->setBounds (hRow.withWidth (side).withX (sq.getX()));
corrMeter->setBounds (sq.getRight() + gap, sq.getY(), barW, side);
balanceMeter->setBounds (sq.getX(), sq.getBottom() + gap, side, barW);
}

void AnamorphAudioProcessorEditor::resized()
Expand Down Expand Up @@ -1321,6 +1342,12 @@ void AnamorphAudioProcessorEditor::resized()

auto r = getLocalBounds();

// Reserve the full-width MULTIBAND bar at the very bottom (advanced only); the
// upper region above it keeps its original 940x720 layout (0.6.7 #2).
juce::Rectangle<int> multiBar;
if (advanced && r.getHeight() > kHeight)
multiBar = r.removeFromBottom (r.getHeight() - kHeight);

// ---- Top bar ----
auto top = r.removeFromTop (46);
{
Expand Down Expand Up @@ -1440,62 +1467,54 @@ void AnamorphAudioProcessorEditor::resized()
}
}

// ---- Advanced bottom rows: a wide INPUT bar over a long MULTIBAND bar ----
// ---- INPUT strip (full left width) ----
if (advanced)
{
auto inputArea = stripArea.removeFromTop (kInputHeight);
auto multiArea = stripArea; // remaining kMultiHeight
auto a = stripArea.reduced (8, 6).reduced (12, 8);
inputModuleLabel.setBounds (a.removeFromTop (15));
a.removeFromTop (6);

// INPUT: a wide, short bar -- combos on the left, the five toggles in the
// middle, the Balance knob on the right (0.6.6 #3 layout change).
{
auto a = inputArea.reduced (8, 6).reduced (12, 8);
inputModuleLabel.setBounds (a.removeFromTop (15));
a.removeFromTop (4);

// Balance knob block on the far right.
auto bal = a.removeFromRight (96);
auto blk = bal.withSizeKeepingCentre (bal.getWidth(), juce::jmin (bal.getHeight(), 92));
balanceL.setBounds (blk.removeFromBottom (14));
balanceK.setBounds (blk.reduced (8, 0));
a.removeFromRight (14);

// Two combos (Channel + Solo) side by side on the left.
auto combos = a.removeFromLeft (310);
{
auto cm = combos.removeFromLeft (150);
auto cmBlk = cm.withSizeKeepingCentre (cm.getWidth(), 43);
channelModeLabel.setBounds (cmBlk.removeFromTop (14));
cmBlk.removeFromTop (3);
channelModeBox.setBounds (cmBlk.removeFromTop (26));
combos.removeFromLeft (10);
auto soBlk = combos.withSizeKeepingCentre (combos.getWidth(), 43);
soloLabel.setBounds (soBlk.removeFromTop (14));
soBlk.removeFromTop (3);
soloBox.setBounds (soBlk.removeFromTop (26));
}
a.removeFromLeft (14);

// Five compact toggles spread across the remaining middle, vertically
// centred so they line up with the combos.
auto tog = a.withSizeKeepingCentre (a.getWidth(), 42);
const int tw = tog.getWidth() / 5;
monoToggle.setBounds (tog.removeFromLeft (tw));
swapToggle.setBounds (tog.removeFromLeft (tw));
msToggle.setBounds (tog.removeFromLeft (tw));
polLToggle.setBounds (tog.removeFromLeft (tw));
polRToggle.setBounds (tog);
}
// Centre a single horizontal row: combos | five toggles | Balance knob.
auto row = a.withSizeKeepingCentre (a.getWidth(), juce::jmin (a.getHeight(), 96));

// MULTIBAND: the long spectral band editor fills the full-width bar under
// its header (label + On toggle).
auto bal = row.removeFromRight (100);
auto blk = bal.withSizeKeepingCentre (bal.getWidth(), juce::jmin (bal.getHeight(), 92));
balanceL.setBounds (blk.removeFromBottom (14));
balanceK.setBounds (blk.reduced (10, 0));
row.removeFromRight (16);

auto combos = row.removeFromLeft (320);
{
auto m = multiArea.reduced (8, 6);
auto head = m.removeFromTop (18).reduced (6, 0);
multibandLabel.setBounds (head.removeFromLeft (head.getWidth() - 56));
mbEnableToggle.setBounds (head.removeFromRight (52));
m.removeFromTop (2);
if (imager) imager->setBounds (m.reduced (2, 0));
auto cm = combos.removeFromLeft (152);
auto cmBlk = cm.withSizeKeepingCentre (cm.getWidth(), 43);
channelModeLabel.setBounds (cmBlk.removeFromTop (14));
cmBlk.removeFromTop (3);
channelModeBox.setBounds (cmBlk.removeFromTop (26));
combos.removeFromLeft (12);
auto soBlk = combos.withSizeKeepingCentre (combos.getWidth(), 43);
soloLabel.setBounds (soBlk.removeFromTop (14));
soBlk.removeFromTop (3);
soloBox.setBounds (soBlk.removeFromTop (26));
}
row.removeFromLeft (16);

auto tog = row.withSizeKeepingCentre (row.getWidth(), 44);
const int tw = tog.getWidth() / 5;
monoToggle.setBounds (tog.removeFromLeft (tw));
swapToggle.setBounds (tog.removeFromLeft (tw));
msToggle.setBounds (tog.removeFromLeft (tw));
polLToggle.setBounds (tog.removeFromLeft (tw));
polRToggle.setBounds (tog);
}

// ---- MULTIBAND: the long, full-width spectral band editor ----
if (advanced && ! multiBar.isEmpty())
{
auto m = multiBar.reduced (8, 6);
auto head = m.removeFromTop (18).reduced (8, 0);
multibandLabel.setBounds (head.removeFromLeft (head.getWidth() - 56));
mbEnableToggle.setBounds (head.removeFromRight (52));
m.removeFromTop (2);
if (imager) imager->setBounds (m.reduced (2, 0));
}
}
36 changes: 23 additions & 13 deletions src/PluginEditor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,15 +113,27 @@ class AnamorphAudioProcessorEditor : public juce::AudioProcessorEditor,
// Preset browser (F2): ‹ name ›, the name opens the preset menu.
juce::TextButton presetPrev, presetNext, presetName;

// Knob: a slider that resets to its default on a clean double-click only --
// a triple-or-more click no longer resets on every extra click (feedback #6).
// Knob: a slider that resets to its default on a clean double-click OR an
// Option/Alt-click (#6 / 0.6.7 #21). onSweep lets the editor play the eased
// position travel when a RESET happens (but not on a drag).
struct Knob : public juce::Slider
{
double resetValue = 0.0;
std::function<void()> onSweep;

void doReset()
{
setValue (resetValue, juce::sendNotificationSync);
if (onSweep) onSweep();
}
void mouseDown (const juce::MouseEvent& e) override
{
if (e.mods.isAltDown()) { doReset(); return; } // Option/Alt-click reset
juce::Slider::mouseDown (e);
}
void mouseDoubleClick (const juce::MouseEvent& e) override
{
if (e.getNumberOfClicks() == 2)
setValue (resetValue, juce::sendNotificationSync);
if (e.getNumberOfClicks() == 2) doReset();
}
};

Expand Down Expand Up @@ -214,15 +226,13 @@ class AnamorphAudioProcessorEditor : public juce::AudioProcessorEditor,
// automation edit leaves it closed, so those snap and never mislead (#3).
double knobSweepTime = 0.0;

// Single fixed window for both modes: toggling Advanced relays out the
// content in place, so the host never resizes us and nothing flickers (#20).
static constexpr int kWidth = 940;
static constexpr int kHeight = 720;
// Advanced bottom rows under the scope (left column): a compact INPUT bar
// above a long, full-width MULTIBAND spectrum bar (0.6.6 #3/#9).
static constexpr int kInputHeight = 150;
static constexpr int kMultiHeight = 176;
static constexpr int kStripHeight = kInputHeight + kMultiHeight; // total reserved
// The upper region is the same 940x720 in both modes, with the scope/meter
// block at its original size (0.6.7 #2). Advanced GROWS the window downward by
// kMultiBarH for a full-width MULTIBAND bar, instead of squeezing the scope.
static constexpr int kWidth = 940;
static constexpr int kHeight = 720; // top bar + scope/INPUT + right panel
static constexpr int kStripHeight = 200; // INPUT strip at the bottom of the left column
static constexpr int kMultiBarH = 196; // full-width Multiband bar, advanced only

JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (AnamorphAudioProcessorEditor)
};
2 changes: 1 addition & 1 deletion src/PluginParameters.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ juce::AudioProcessorValueTreeState::ParameterLayout createAnamorphLayout()
floatParam (pid::width, "Width", { 0.0f, 2.0f, 0.001f }, 1.0f, pct, pctFrom);

// --- Multiband (1..4 bands, up to 3 crossovers) ---
layout.add (std::make_unique<AudioParameterBool> (ParameterID { pid::mbEnable, kVersion }, "Multiband Enable", false));
layout.add (std::make_unique<AudioParameterBool> (ParameterID { pid::mbEnable, kVersion }, "Multiband Enable", true));
layout.add (std::make_unique<juce::AudioParameterInt> (ParameterID { pid::mbBands, kVersion }, "Multiband Bands", 1, 4, 4));
floatParam (pid::mbFreqLow, "Multiband Split 1", logFreqRange (30.0f, 600.0f), 180.0f, hz, hzFrom);
floatParam (pid::mbFreqMid, "Multiband Split 2", logFreqRange (150.0f, 3000.0f), 800.0f, hz, hzFrom);
Expand Down
16 changes: 13 additions & 3 deletions src/dsp/AnamorphEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,11 +478,21 @@ void AnamorphEngine::process (juce::AudioBuffer<float>& buffer) noexcept
if (pendingForced)
{
snapSmoothers();
// Clear the band/mono crossover state too: their IIR filters still hold
// the OLD signal, and a big crossover/width jump would otherwise ring as
// the duck fades back in -- audible as the residual "burst" (0.6.6 #1).
// Clear EVERY stateful node so the fade-in plays the new state from a
// clean slate. Even a SAME-algorithm A/B can move Haas delay / Chorus
// rate / Drive far enough that the old delay-line + filter + oversampler
// contents replay as a short glitch right as the duck lifts -- the
// intermittent A/B "weird sound" (0.6.7 #22). At the silent bottom these
// resets are inaudible.
multiband.reset();
monoMaker.reset();
haas.reset();
velvet.reset();
chorus.reset();
if (os2) os2->reset();
if (os4) os4->reset();
if (os8) os8->reset();
pendingAlgoReset = false; // already handled by the wholesale reset above
const float inj = matchInject.exchange (kNoInject, std::memory_order_relaxed);
if (inj > kNoInject + 1.0f)
{
Expand Down
Loading
Loading