v0.6.5: short masking duck on A/B / preset / undo switches to kill the level pop#23
Merged
Merged
Conversation
…e level pop A large A/B or preset jump can move many parameters (and instantly re-inject the per-slot Level-Match gain) at once, popping. The engine already masks discrete switches with a ~4 ms raised-cosine duck; it now also accepts a forced-duck request so the SAME masking runs for a bulk swap even when only continuous controls changed. The wrapper requests the duck BEFORE the parameters change -- in abSwitchTo / undo / redo, and from the editor before a preset load / step / file load -- so the duck is already running when the new values arrive. https://claude.ai/code/session_01Y38PtwPxh2geBLta6yuUwv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anamorph 0.6.4 feedback — 1 item.
A short masking duck on A/B and preset switches kills the level-jump pop.
A large A/B or preset switch can move many parameters at once — and an A/B switch also instantly re-injects that slot's remembered Level-Match gain (
setCurrentAndTargetValue, not ramped) — which together can pop on a big level change. The engine already masks every discrete switch (algorithm/routing/bypass) with a ~4 ms raised-cosine duck (fade to silence, swap, fade back, zero-slope at the seam). It now also accepts arequestDuck()so the same masking runs for a bulk swap even when only continuous controls changed.The wrapper requests the duck before the parameters change, so the duck is already running when the new values arrive:
abSwitchTo,undo,redo(in the processor)‹ ›prev/next, the menu Load, and the OS file loadNo new parameter, no latency change, and the duck is the existing proven click-free mechanism (same ~4 ms each way used for algorithm changes). Continuous controls still respond immediately and remain smoothed.
Gates: 14/14 DSP self-tests · no new compiler warnings · pluginval strictness 10 PASSED.
https://claude.ai/code/session_01Y38PtwPxh2geBLta6yuUwv
Generated by Claude Code