Skip to content
This repository was archived by the owner on Sep 28, 2022. It is now read-only.

fix: Update ganache cli#73

Open
rafinskipg wants to merge 1 commit into
dai.jsfrom
fix/update-ganache-cli
Open

fix: Update ganache cli#73
rafinskipg wants to merge 1 commit into
dai.jsfrom
fix/update-ganache-cli

Conversation

@rafinskipg

Copy link
Copy Markdown

Why:

  • ganache-cli has been updating stuff

Dangers:

  • I didn't test the testchain correctly with this ganache-cli version. Need someone to verify correctness.

@b-pmcg

b-pmcg commented Jul 8, 2021

Copy link
Copy Markdown
Contributor

@rafinskipg let's wait until we get everything working with the vote-delegate contract, I want to change as little as possible to get to parity. I think that fork of ganache-cli has a fix for a gas issue. @tyler17 do you remember what the reason was for that?

@tyler17

tyler17 commented Jul 10, 2021

Copy link
Copy Markdown
Collaborator

Copying my comment from rocket chat here:

The story is that the fork was originally made so that we could use a ganche-cli fix before it got included in their release. Then I recently tried updating ganache-ci to the latest version in the testchain, but doing so caused one of the dai.js tests relating to multicall to fail, so I didn't go through with that update. But it's something we should revisit, as updating ganache-cli also allowed for using the testchain in metamask

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants