This repository was archived by the owner on Sep 28, 2022. It is now read-only.
fix: Update ganache cli#73
Open
rafinskipg wants to merge 1 commit into
Open
Conversation
Contributor
|
@rafinskipg let's wait until we get everything working with the vote-delegate contract, I want to change as little as possible to get to parity. I think that fork of ganache-cli has a fix for a gas issue. @tyler17 do you remember what the reason was for that? |
Collaborator
|
Copying my comment from rocket chat here: The story is that the fork was originally made so that we could use a ganche-cli fix before it got included in their release. Then I recently tried updating ganache-ci to the latest version in the testchain, but doing so caused one of the dai.js tests relating to multicall to fail, so I didn't go through with that update. But it's something we should revisit, as updating ganache-cli also allowed for using the testchain in metamask |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Dangers: