Skip to content

place the class into a psr-0 setup so that other modules can #1

Open
alnutile wants to merge 1 commit into
skwashd:7.x-1.xfrom
alnutile:7.x-1.x
Open

place the class into a psr-0 setup so that other modules can #1
alnutile wants to merge 1 commit into
skwashd:7.x-1.xfrom
alnutile:7.x-1.x

Conversation

@alnutile

Copy link
Copy Markdown

Use psr-0 to extend or include the class

Using

use GithubApi\DrupalGithubApiHttpClientCacheDrupalNativeCache;

and / or

class SomeOtherClass extends DrupalGithubApiHttpClientCacheDrupalNativeCache

This way there is a more constant coding standard and not using *.info to include the file.

@skwashd

skwashd commented Sep 2, 2014

Copy link
Copy Markdown
Owner

@alnutile I'm open to do this, but the patch doesn't apply cleanly. The patch also loses the history of the class, you need to do a git mv. Please re-roll it.

@alnutile

alnutile commented Sep 2, 2014

Copy link
Copy Markdown
Author

Cool will trying do it 2 night.

-----Original Message-----
From: "Dave Hall" notifications@github.com
Sent: ‎9/‎2/‎2014 5:43 AM
To: "skwashd/github_api" github_api@noreply.github.com
Cc: "Alfred Nutile" alfrednutile@gmail.com
Subject: Re: [github_api] place the class into a psr-0 setup so that othermodules can (#1)

@alnutile I'm open to do this, but the patch doesn't apply cleanly. The patch also loses the history of the class, you need to do a git mv. Please re-roll it.

Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants