Title, Volume and remote Mp3 files fix#491
Merged
Merged
Conversation
Replaced url with selfhosted url
skorokithakis
approved these changes
Mar 14, 2026
skorokithakis
left a comment
skorokithakis
left a comment
Owner
There was a problem hiding this comment.
Hm, I'm not crazy about the tests depending on someone's server, but it's good enough for now, thanks!
Contributor
Author
|
I know its not the best solution, but i dont know how else we would test remote mp3 playback without it. If it stops working someday, we can also just remove the test. I see that it failed the pre-commit because of formatting. I just formatted and pushed again. |
skorokithakis
approved these changes
Mar 14, 2026
Owner
|
Makes sense, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability to provide title (useful for the mp3 media player) and volume when casting.
Also remote mp3 files didnt work before, now they do instead of saying "no suitable format found"
Example:
catt -d Office cast https://file-examples.com/storage/fede0b421769af5709b2497/2017/11/file_example_MP3_700KB.mp3 --title "This is a title" --volume 20oh, also output as json gives more info now