実践ラボを単一焦点のミッション画面へ再設計 - #6
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5aecfc374b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {selectedNodeId === node.id ? ( | ||
| <button | ||
| type="button" | ||
| className="mobile-map-action" | ||
| data-testid="next-action-mobile" | ||
| onClick={onOpenNode} |
There was a problem hiding this comment.
When the selected node occurs late in the projection, the primary action is buried at that node's unchanged list position. For example, the success fixture selects map-13 after twelve preceding rows, so at mobile widths the initial screen contains neither the selected place nor 次の一手; the learner must scroll almost the entire route to reach the only way to continue. Preserve the selected row/action near the visible portion of the route or provide a persistent action.
AGENTS.md reference: apps/lab-guide/AGENTS.md:L9-L9
Useful? React with 👍 / 👎.
| const stateLabel = | ||
| selected | ||
| ? "選択中" | ||
| : node.state === "discovered" | ||
| ? "発見済み" | ||
| : "未発見"; |
There was a problem hiding this comment.
When a learner selects a different discovered node, the projection's original state: "selected" node no longer satisfies either of the first two branches and is visibly labelled 未発見, even though it remains an operable discovered node. This presents contradictory map state; every non-undiscovered node that is not the current local selection should be labelled 発見済み.
AGENTS.md reference: apps/lab-guide/AGENTS.md:L9-L9
Useful? React with 👍 / 👎.
1 participant
変更内容
検証
境界
物理KaliからDebian実機への接続試験、デュアルブート導入、復旧イメージ、隔離確認は今回も未実施です。