Move the modifiable variables to defcustom#9
Open
christophe-gouel wants to merge 1 commit into
Open
Conversation
…and start text - Introduced ~defgroup~ for ~ess-essgd~ customization group. - Changed ~defvar~ to ~defcustom~ for ~essgd-buffer~, ~essgd-debug~, and ~essgd-start-text~.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was not happy with the display of plots when using a dark theme, because the grids or the labels were not very visible (or not at all). So, I switched to the default of httgd, which is using a white background. For this, I had to go in essgd code to understand how to set this in the variable
essgd-start-text. To make this discovery easier for the users, I am proposing in this pull request to move the variables that can be set by the users todefcustomso that they can be discovered and customized easily in Emacs usingcustomize-group.