Show secondary-language actor name in list when primary is empty#363
Open
level09 wants to merge 1 commit into
Open
Show secondary-language actor name in list when primary is empty#363level09 wants to merge 1 commit into
level09 wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BYNT-1719.
Two parts:
gen_full_namejoined name parts unconditionally, so a Person created with only Arabic names gotname = " "(a truthy single space). That junk value defeated thename or Noneguard in serialization and also pollutes the search vector. It now joins only non-empty parts.item.namedirectly, showing blank for such actors. The name column now falls back toname_arwhen the primary name is empty (trimmed, so existing rows with the legacy" "value display correctly without a data migration).The preview card, relate dialogs, and search results already render both languages, so the list column was the only blank surface. Kept the fallback display-side to avoid feeding
name_arinto the editablenamefield of the edit dialog for entities.