Skip to content

Show secondary-language actor name in list when primary is empty#363

Open
level09 wants to merge 1 commit into
mainfrom
fix/actor-name-fallback
Open

Show secondary-language actor name in list when primary is empty#363
level09 wants to merge 1 commit into
mainfrom
fix/actor-name-fallback

Conversation

@level09

@level09 level09 commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Fixes BYNT-1719.

Two parts:

  1. gen_full_name joined name parts unconditionally, so a Person created with only Arabic names got name = " " (a truthy single space). That junk value defeated the name or None guard in serialization and also pollutes the search vector. It now joins only non-empty parts.
  2. The actors list rendered item.name directly, showing blank for such actors. The name column now falls back to name_ar when the primary name is empty (trimmed, so existing rows with the legacy " " value display correctly without a data migration).

The preview card, relate dialogs, and search results already render both languages, so the list column was the only blank surface. Kept the fallback display-side to avoid feeding name_ar into the editable name field of the edit dialog for entities.

@level09 level09 requested a review from apodacaduron as a code owner July 11, 2026 12:35
@level09 level09 self-assigned this Jul 11, 2026
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 39331bda-e40a-46c6-882b-87c47f181e2b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/actor-name-fallback

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant