Skip to content

Export all media files per item instead of only the first #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
level09 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Export all media files per item instead of only the first #362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06f6680
fix(export): include all media files per item instead of only the first
level09 Jul 11, 2026
abd3964
refactor(export): create s3 client once outside media loop
level09 Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions enferno/tasks/exports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,16 @@ def generate_export_media(previous_result: int) -> t.id | Literal[False]:
# UI switch disabled, but just in case...
return False

if not cfg.FILESYSTEM_LOCAL:
s3 = boto3.client(
"s3",
aws_access_key_id=cfg.AWS_ACCESS_KEY_ID,
aws_secret_access_key=cfg.AWS_SECRET_ACCESS_KEY,
region_name=cfg.AWS_REGION,
)

for item in items:
if item.medias:
media = item.medias[0]
for media in item.medias:
target_file = f"{Export.export_dir}/{export_request.file_id}/{media.media_file}"

if cfg.FILESYSTEM_LOCAL:
Expand All @@ -281,12 +288,6 @@ def generate_export_media(previous_result: int) -> t.id | Literal[False]:
clear_failed_export(export_request)
return False # to stop chain
else:
s3 = boto3.client(
"s3",
aws_access_key_id=cfg.AWS_ACCESS_KEY_ID,
aws_secret_access_key=cfg.AWS_SECRET_ACCESS_KEY,
region_name=cfg.AWS_REGION,
)
try:
s3.download_file(cfg.S3_BUCKET, media.media_file, target_file)
except Exception:
Expand All @@ -297,7 +298,7 @@ def generate_export_media(previous_result: int) -> t.id | Literal[False]:
clear_failed_export(export_request)
return False # to stop chain

time.sleep(0.05)
time.sleep(0.05)
return export_request.id


Expand Down
Loading