Fix advanced search refine/extend combination logic#361
Open
level09 wants to merge 2 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BYNT-1760.
Multi-block advanced search (Refine/Extend) combined query blocks incorrectly in two ways:
or_(*conditions, *next_conditions)OR-ed every individual condition instead of(block1) OR (block2). A block with "tag X AND access group G" degraded to "tag X OR access group G", inflating results.orbranch read from the first block's condition list instead of the accumulated result, so with three or more blocks intermediate blocks were silently discarded.Both bulletin and actor paths are fixed with a left-associative fold: each block's conditions are grouped with AND, then combined with the accumulated query using the block's op. Empty blocks are skipped.
Added focused tests compiling the generated SQL for grouping, chained ORs, and AND-after-OR.
Present since the search rewrite in #97, so this affects existing deployments, not just recent branches.