/ballot-design: Add optional election homepage field - #302
Open
Arkshine wants to merge 3 commits into
Open
Conversation
|
@Arkshine is attempting to deploy a commit to the SIV Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Member
|
Nice, in general, this is cool. Giving this single setting its own admin-dashboard page and sidebar link feels too prominent, though. It's very rarely used, and feels like it would clutter things up a lot of the time. It could live on the /ballot-design page though, under the main ballot-schema editor. |
Arkshine
force-pushed
the
add-admin-election-homepage-field
branch
from
April 9, 2026 18:29
e8f9a7e to
cbb50ed
Compare
Arkshine
changed the title
Contributor
Author
|
Thanks for the feedback! Changes are pushed. I tried to match the style. Also added URL validation. Image in the first post updated and title as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR wires up an optional election homepage URL setting to
election_homepagefield.Hopefully, I did not forget something.