Skip to content
This repository was archived by the owner on Feb 21, 2026. It is now read-only.

pause/resume waveOut option defaults to old behaviour#11

Open
finebytes wants to merge 3 commits into
sipsorcery-org:masterfrom
finebytes:affect-both-directions-on-pause-resume-audio
Open

pause/resume waveOut option defaults to old behaviour#11
finebytes wants to merge 3 commits into
sipsorcery-org:masterfrom
finebytes:affect-both-directions-on-pause-resume-audio

Conversation

@finebytes

Copy link
Copy Markdown

PauseAudio() and ResumeAudio() are only pausing _waveInEvent in WindowsAudioEndPoint but optionally _waveOutEvent needs to be paused as well. #10

@fred-peters

fred-peters commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

Hi finebytes, according to my understanding of the project, PauseAudio and ResumeAudio are implmentation of the IAudioSource and not IAudioSink, that's why they should not deal with waveOutEvent., that's the purpose of the IAudioSink interface.
If you need a generic (in/out) PauseAudio, this should be implemented at the VoipMediaSession level.
This is unfortunate that the naming of the IAudioSource methods is generic (PauseAudio and ResumeAudio, it should be renamed to PauseAudioSource and ResumeAudioSource like it is correctly done of the IAudioSink interface which has PauseAudioSink and PauseAudioSource methods)

@sipsorcery

Copy link
Copy Markdown
Member

Is this still required after #12?

@fred-peters

Copy link
Copy Markdown
Contributor

I Suggest to rename the existing methods as described in my previous comment so it will be consistent with the other already existing PauseAudioSink and PauseAUdioSource, but not implement this change request which would create an asymetric behaviour

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants