feat: add o-top-level-side-effects rule#2937
Closed
uwufuzzywiiiaisddd wants to merge 1 commit intosindresorhus:mainfrom
Closed
feat: add
o-top-level-side-effects rule#2937uwufuzzywiiiaisddd wants to merge 1 commit intosindresorhus:mainfrom
uwufuzzywiiiaisddd wants to merge 1 commit intosindresorhus:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
no-top-level-side-effectsrule, which flags top-level executable statements in ES modules.\n\nAddresses the issues noted in #2870 and #2912:\n-export default foo()now correctly flagged\n-void foo(),condition && foo(), top-levelif/for/while/tryall flagged\n-UnaryExpressionhandled soexport default -1is not a false positive\n- Template literal embedded expressions checked\n-module.id = 1(non-exports assignment) correctly flagged\n- Files without any exports treated as scripts (no errors)\n- Hashbang files treated as scripts\n- Pure annotation support (@__PURE__,#__PURE__,@__NO_SIDE_EFFECTS__)