Skip to content

feat: add Google logo to speaker card#43

Merged
AbelGAlem merged 8 commits into
mainfrom
feature/google_logo
Jun 17, 2026
Merged

feat: add Google logo to speaker card#43
AbelGAlem merged 8 commits into
mainfrom
feature/google_logo

Conversation

@ville5367

@ville5367 ville5367 commented May 26, 2026

Copy link
Copy Markdown
Contributor

Added Google logo next to Web AI Lead Jason Mayes.

@ville5367 ville5367 requested a review from otsosaarinen as a code owner May 26, 2026 13:29
@vercel

vercel Bot commented May 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sinceai-fi Ready Ready Preview, Comment Jun 17, 2026 10:49am

@github-actions github-actions Bot added the components Changes to React components label May 26, 2026

@otsosaarinen otsosaarinen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good PR already but do these couple of changes so it's good to merge and keeps our code base pretty.

  1. Move GoogleLogo_FullColor_RGB.png to public/assets/speakers/. Jason's picture is also there and this logo is meant for same section so it's proper place for the logo. public/assets/logo folder is mostly just for the Since AI logos.

  2. Use conventional commits style for the commit message. Current commit message Added google logo doesn't follow this style. You can check this for more information https://github.com/sinceaihq/sinceai?tab=contributing-ov-file#commit-messages. Also you can use command git commit --amend -m "feat: add Google logo to speaker card" to change your most recent commit.

  3. Code block from row 120 to 134 in FeaturedSpeakers.tsx is misaligned:

<div className="flex items-center gap-0 mt-2">
                      <p className="text-sm text-neutral-400">
                          {speaker.title}
                      </p>
                      {speaker.companyLogo && (
                          <Image
                              src={speaker.companyLogo}
                              alt={`${speaker.company} logo`}
                              width={80}
                              height={18}
                              className="object-contain"
                          />
                      )}
                  </div>

Just check here that the codeblock is indented correctly in the code editor, code itself is fine.

  1. In FeaturedSpeakers.tsx row 138, remove gap-0 from the styling. It doesn't do anything here so there is no need to add it. Everything is gap-0 by default.

  2. I would change the logo image to this https://brandfetch.com/google.com?library=default&collection=logos&asset=id2S08J5oA. I think full white logo fits the black/white theme better than default Google logo because it's so colorful.

@otsosaarinen

Copy link
Copy Markdown
Member

Also remember to write PR description :)

@ville5367 ville5367 changed the title Added google logo feat: add Google logo to speaker card Jun 4, 2026
Used autoformat on the page to fix formatting errors.
Changed Google logo to a white one.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@AbelGAlem AbelGAlem merged commit 352d202 into main Jun 17, 2026
9 checks passed
@AbelGAlem AbelGAlem deleted the feature/google_logo branch June 17, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

components Changes to React components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants