feat: add Google logo to speaker card#43
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pretty good PR already but do these couple of changes so it's good to merge and keeps our code base pretty.
-
Move
GoogleLogo_FullColor_RGB.pngtopublic/assets/speakers/. Jason's picture is also there and this logo is meant for same section so it's proper place for the logo.public/assets/logofolder is mostly just for the Since AI logos. -
Use conventional commits style for the commit message. Current commit message
Added google logodoesn't follow this style. You can check this for more information https://github.com/sinceaihq/sinceai?tab=contributing-ov-file#commit-messages. Also you can use commandgit commit --amend -m "feat: add Google logo to speaker card"to change your most recent commit. -
Code block from row 120 to 134 in
FeaturedSpeakers.tsxis misaligned:
<div className="flex items-center gap-0 mt-2">
<p className="text-sm text-neutral-400">
{speaker.title}
</p>
{speaker.companyLogo && (
<Image
src={speaker.companyLogo}
alt={`${speaker.company} logo`}
width={80}
height={18}
className="object-contain"
/>
)}
</div>
Just check here that the codeblock is indented correctly in the code editor, code itself is fine.
-
In
FeaturedSpeakers.tsxrow 138, removegap-0from the styling. It doesn't do anything here so there is no need to add it. Everything isgap-0by default. -
I would change the logo image to this https://brandfetch.com/google.com?library=default&collection=logos&asset=id2S08J5oA. I think full white logo fits the black/white theme better than default Google logo because it's so colorful.
|
Also remember to write PR description :) |
Used autoformat on the page to fix formatting errors. Changed Google logo to a white one.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Added Google logo next to Web AI Lead Jason Mayes.