ntf server: concurrent notification delivery#1779
Merged
Merged
Conversation
Change PPRetryLater from nullary to PPRetryLater Text so the cause (503 / 410-reason) propagates to the retry call site. Log a warning at every retry attempt with provider, token id and reason.
Fork delivery per notification, taking an MVar keyed by srvHost_ so notifications from the same SMP server serialize while different servers proceed concurrently. Switch APNS to sendRequestDirect so concurrent deliveries share one HTTP/2 connection via stream multiplexing rather than serializing through the client reqQ.
shumvgolove
force-pushed
the
sh/ntf-debug
branch
2 times, most recently
from
6789bc3 to
5e90939
Compare
Match the take/create/wait pattern in Agent/Client.hs (newProtocolClient / waitForProtocolClient). pushClients now wraps clients in SessionVar (Either SomeException PushProviderClient) so concurrent first-time access and concurrent retries collapse to a single mkClient call; waiters observe the winner's result via readTMVar (or its error). retryDeliver evicts the failing client by SessionVar identity before re-fetching.
evgeny-simplex
force-pushed
the
sh/ntf-debug
branch
2 times, most recently
from
c1c9796 to
915a0c7
Compare
evgeny-simplex
force-pushed
the
sh/ntf-debug
branch
from
915a0c7 to
992950f
Compare
evgeny-simplex
force-pushed
the
sh/ntf-debug
branch
from
ac8b57e to
a53323f
Compare
epoberezkin
changed the title
epoberezkin
pushed a commit
that referenced
this pull request
May 18, 2026
The per-(srvHost, provider) worker shards added in #1779 still funnel all APNS sends through one HTTP2Client's reqQ, where a single process thread calls sendRequest serially - one in-flight HTTP/2 stream at a time, capping APNS throughput at 1/RTT. sendRequestDirect bypasses the queue and invokes sendReq directly from the calling worker, so concurrent workers open parallel HTTP/2 streams on the shared APNS connection and the multiplexing happens on the wire.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.