Skip to content

Bugfix "Cannot read property 'context' of undefined` in update callback"#29

Open
joshiste wants to merge 1 commit into
simplesmiler:masterfrom
joshiste:bugfix/context-of-undefined
Open

Bugfix "Cannot read property 'context' of undefined` in update callback"#29
joshiste wants to merge 1 commit into
simplesmiler:masterfrom
joshiste:bugfix/context-of-undefined

Conversation

@joshiste

Copy link
Copy Markdown

when update is called the vnode isn't passed and this results in an error. This commit fixes this.
Would be glad if you would release this fix soon.

@joshiste

Copy link
Copy Markdown
Author

The bug was introduced with bfc4517

@joshiste

Copy link
Copy Markdown
Author

@simplesmiler did you have a look on this one?

@jmduke

jmduke commented May 10, 2018

Copy link
Copy Markdown

🙏 Running into this myself!

@joshiste

joshiste commented Jun 8, 2018

Copy link
Copy Markdown
Author

@simplesmiler is this project dead?

@MarineLB

Copy link
Copy Markdown

having the same problem with nuxt

@silverspectro

Copy link
Copy Markdown

Hello !
I have forked the project because i need this fix for my work.
I will surely add your MR, so if you want, here it is :) : https://github.com/silverspectro/vue-clickaway

@joshiste

Copy link
Copy Markdown
Author

@silverspectro will you publish on npmjs.org?

@silverspectro

Copy link
Copy Markdown

sure, i can do that, but i can't use the same repo name as the first i think. So i don't know how to do that, as it would be cool to keep the same npm repo and just change the maintainers and github repo behind maybe ?
@simplesmiler would it be ok for you ? Have you any intention to maintain this project further ? If not, i would be willing to do it (at least check the MR and do some code reviews). Do you have any ideas about this ?

@joshiste

Copy link
Copy Markdown
Author

@silverspectro you could fork it and publish with a different name

@silverspectro

silverspectro commented Aug 15, 2018

Copy link
Copy Markdown

Hello!

Package published under a new very original name in npm: vue-clickaway2.
Normally everything should work fine (tested on my project).

I did it a bit hastily so there may be some errors in the README or something still.
Feel free to PR on it, I'll respond.
Here is the new repo: https://github.com/silverspectro/vue-clickaway2

Hope it helps.
Cheers,

@espindolaa

espindolaa commented Jan 30, 2019

Copy link
Copy Markdown

I know this is a old thread, but I wanted to thank @joshiste and @silverspectro for doing this.
Was running into a very specific bug, using clickaway with svgicon and the new repo fixed it perfectly.

Thank you very much.

@Prechan

Prechan commented May 21, 2019

Copy link
Copy Markdown

Any news about this PR @simplesmiler ? That would be great to avoid multiply forks !

@TPXP

TPXP commented Sep 20, 2020

Copy link
Copy Markdown

Ran into this issue today and can confirm that vue-clickaway2 works properly. Thanks @silverspectro <3

@iampava

iampava commented Nov 2, 2020

Copy link
Copy Markdown

Just changed to vue-clickaway2 in our project due to this bug. Thanks a log for forking and publishing as a separate package!

@nVitius

nVitius commented Jan 18, 2021

Copy link
Copy Markdown

@simplesmiler can you merge this in and redeploy to npm? If you need a new maintainer for the library, let me know.

@ronssij

ronssij commented Jun 23, 2022

Copy link
Copy Markdown

I am also experiencing this on bind.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants