Implement form_post response mode#337
Open
Harm-r wants to merge 14 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## wip-version-7 #337 +/- ##
===================================================
- Coverage 46.88% 46.88% -0.01%
- Complexity 2041 2074 +33
===================================================
Files 166 171 +5
Lines 8662 8816 +154
===================================================
+ Hits 4061 4133 +72
- Misses 4601 4683 +82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements support for the form_post response mode, specifically:
To achieve this, I've refactored the code to use an instance of the ResponseModeInterface for returning responses, instead of a hardcoded queryDelimiter parameter.
This work has been done during the 11th cycle of the T&I Incubator at GÉANT.