Skip to content

Update notebooks.yml#3

Open
ValiDM wants to merge 1 commit into
simplecastapps:mainfrom
ValiDM:patch-1
Open

Update notebooks.yml#3
ValiDM wants to merge 1 commit into
simplecastapps:mainfrom
ValiDM:patch-1

Conversation

@ValiDM

@ValiDM ValiDM commented Jun 13, 2024

Copy link
Copy Markdown

Add Alienware block to regex list

Add Alienware block to regex list
@mindreader

Copy link
Copy Markdown
Contributor

This is probably fine, but for non code related fixes, it is required to submit them upstream to https://github.com/matomo-org/device-detector.git.

They will require a test to go with your changes.

Once that is approved, this library will pull those changes naturally.

@mindreader

Copy link
Copy Markdown
Contributor

An alternative, if you have real world examples of the user agent in the wild, let me know here, and I'll add it to my next pr that I send up.

@liviuconcioiu

Copy link
Copy Markdown

@mindreader I was able to find this user-agent. Feel free to open a PR when you have time.

Mozilla/5.0 (Windows NT 10.0.18362.356; osmeta 10.3.45364) AppleWebKit/602.1.1 (KHTML, like Gecko) Version/9.0 Safari/602.1.1 osmeta/10.3.45364 Build/45364 FBAN/FBW;FBAV/186.0.0.88.783;FBBV/171658047;FBDV/AlienwareAuroraR70858;FBMD/Alienware Aurora R7 0858;FBSN/Windows;FBSV/10.0.18362.657;FBSS/2;FBCR/;FBID/desktop;FBLC/en_US;FBOP/45;FBRV/0

@mindreader

mindreader commented Jun 20, 2024 via email

Copy link
Copy Markdown
Contributor

@mindreader

Copy link
Copy Markdown
Contributor

Submitted upstream. matomo-org/device-detector#7717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants