Skip to content

Fix: Enable baseDnsZone support for single-image stacks (AWS Lambda)#71

Merged
universe-ops merged 1 commit into
mainfrom
staging
Jan 16, 2026
Merged

Fix: Enable baseDnsZone support for single-image stacks (AWS Lambda)#71
universe-ops merged 1 commit into
mainfrom
staging

Conversation

@universe-ops

Copy link
Copy Markdown
Contributor

Problem

The baseDnsZone configuration was working correctly for cloud-compose stacks (ECS Fargate) but not for single-image stacks (AWS Lambda). While the field was defined in StackConfigSingleImage, the AWS Lambda implementation wasn't properly exposing it through the required OverriddenBaseZone() interface method.

Root Cause

  • EcsFargateInput had a BaseDnsZone field and implemented OverriddenBaseZone() method ✅
  • LambdaInput was missing the OverriddenBaseZone() method ❌
  • This prevented DNS zone override functionality from working with AWS Lambda deployments

Solution

Added the missing OverriddenBaseZone() method to LambdaInput that returns l.StackConfig.BaseDnsZone directly, eliminating the need for field duplication.

Changes

  • Added: OverriddenBaseZone() method to LambdaInput struct in pkg/clouds/aws/aws_lambda.go
  • Implementation: Returns l.StackConfig.BaseDnsZone directly (clean, no field duplication)

Impact

  • baseDnsZone configuration now works for single-image stacks (AWS Lambda)
  • ✅ Feature parity between cloud-compose and single-image deployment types
  • ✅ Clean implementation without unnecessary field duplication

Usage Example

# client.yaml - Now works for single-image stacks!
stacks:
  my-lambda:
    type: single-image
    config:
      baseDnsZone: "my-custom-zone.com"
      domain: "api.my-custom-zone.com"
      # ... other config

Testing

  • Code compiles successfully
  • Follows existing patterns from ECS Fargate implementation
  • No breaking changes to existing functionality

@universe-ops
universe-ops merged commit 6ce7246 into main Jan 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants