Restore integration tests with numeric tolerance#477
Merged
Conversation
Introduce a 1% numeric relative tolerance in RunSimPathsIntegrationTest and use numbersMatchWithTolerance for numeric comparisons. Adjust test_run.yml to run a single run (maxNumberOfRuns=1) with randomSeed=606 and popSize=50000. Regenerate expected CSV outputs to match the updated run (AlignmentAdjustmentFactors1.csv, EmploymentStatistics1.csv, HealthStatistics1.csv, Statistics1.csv, Statistics21.csv).
Increase integration runs in test config (maxNumberOfRuns 1->2), adjust randomSeed and popSize, and update the numeric comparison in RunSimPathsIntegrationTest to use combined absolute+relative epsilons with proper NaN/Infinity handling (remove old tolerance method). Update expected integration output CSVs to include results for the additional runs and reflect the seed/population changes (AlignmentAdjustmentFactors1.csv, EmploymentStatistics1.csv, HealthStatistics1.csv, Statistics1.csv, Statistics21.csv).
andrewbaxter439
approved these changes
Jun 2, 2026
andrewbaxter439
left a comment
andrewbaxter439
left a comment
Collaborator
There was a problem hiding this comment.
Hey this looks good, and if passing tests when running all seems a good move to have this back in. Should be sensitive enough to 'keep an eye' on the runs as new pulls come in and check that they're not differing where you wouldn't expect them to be. Think this can go ahead. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a numeric relative and absolute tolerance in
RunSimPathsIntegrationTest. Regenerate expected CSV outputs to match the updated run (AlignmentAdjustmentFactors1.csv, EmploymentStatistics1.csv, HealthStatistics1.csv, Statistics1.csv, Statistics21.csv).