Fix progress bar byte count for multibyte encodings (e.g. utf-16-le)#810
Open
ikatyal2110 wants to merge 1 commit into
Open
Fix progress bar byte count for multibyte encodings (e.g. utf-16-le)#810ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
…multibyte encodings UpdateWrapper.__iter__ and .read() used len(line) which counts decoded characters, but the progress bar total comes from os.path.getsize() (raw bytes). For encodings like utf-16-le each character is 2 bytes, so the bar would only reach ~50%. Encode the string back with the file's encoding to get the correct byte length. Fixes simonw#439
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpdateWrapper.iter and .read() called len() on decoded text strings, but the progress bar total is set from os.path.getsize() which returns raw bytes. For multibyte encodings like utf-16-le each character is 2 bytes, so the bar would only reach ~50% before the insert finished. This fix encodes each string back with the file's encoding before measuring length so the byte counts match. Fixes #439
Generated by Claude Code
📚 Documentation preview 📚: https://sqlite-utils--810.org.readthedocs.build/en/810/