Fix TypeTracker inferring wrong type for CSV columns containing only empty strings#807
Open
ikatyal2110 wants to merge 1 commit into
Open
Fix TypeTracker inferring wrong type for CSV columns containing only empty strings#807ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
`ValueTracker.evaluate()` used `if not value` to skip NULL values, but this also skipped empty strings (`""`), `0`, and other falsy values. A CSV column containing only empty strings was incorrectly inferred as INTEGER (the initial default) instead of TEXT. Replace the falsy check with an explicit `if value is None` so that only NULL is skipped and all other values — including `""` — are evaluated against the type tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValueTracker.evaluate() used
if not valueto skip None, but this also skipped empty strings (""), causing a CSV column whose every row is blank to be typed as INTEGER (the initial default) rather than TEXT. The fix replaces the falsy check with an explicitif value is Noneso only actual NULL values are skipped and empty strings are passed through the type tests, which correctly eliminate integer and float as candidates.Generated by Claude Code
📚 Documentation preview 📚: https://sqlite-utils--807.org.readthedocs.build/en/807/