Skip to content

Fix incorrect tool metadata logging in log_to_db#1451

Open
krrish612 wants to merge 1 commit into
simonw:mainfrom
krrish612:fix-log-to-db-tool-shadowing
Open

Fix incorrect tool metadata logging in log_to_db#1451
krrish612 wants to merge 1 commit into
simonw:mainfrom
krrish612:fix-log-to-db-tool-shadowing

Conversation

@krrish612
Copy link
Copy Markdown

Conclusion

Fixed a variable shadowing bug in log_to_db() which resulted in tool results being logged with incorrect tool metadata.

Changes to the manual

  • Added explicit tool lookup with tool_result.name
  • Fixed wrong references to outer scoped tool
  • removed stale TODO comment

Authentication

  • Tool tests completed
  • Unrelated existing failing test untouched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant